-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locals in exclusive systems #3946
Closed
TheRawMeatball
wants to merge
6
commits into
bevyengine:main
from
TheRawMeatball:locals-in-exclusive-systems
Closed
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9e67da3
Add more FromWorld implementations
TheRawMeatball 3667ac4
Add Local support to exclusive systems
TheRawMeatball 5912dd5
fix errors
TheRawMeatball b7ff9a4
Add example
TheRawMeatball 87c335b
Update examples/ecs/exclusive_system_tricks.rs
TheRawMeatball 7f833c9
Improve example
TheRawMeatball File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ mod spawn_batch; | |
mod world_cell; | ||
|
||
pub use crate::change_detection::Mut; | ||
use bevy_ecs_macros::all_tuples; | ||
pub use entity_ref::*; | ||
pub use spawn_batch::*; | ||
pub use world_cell::*; | ||
|
@@ -1224,6 +1225,25 @@ impl<T: Default> FromWorld for T { | |
} | ||
} | ||
|
||
/// Wrapper type to enable getting multiple [`FromWorld`] types in one type. | ||
/// | ||
/// This wrapper is necessary because a [`FromWorld`] implementation for a tuple of | ||
/// [`FromWorld`] implementing types would conflict with the [`FromWorld`] impl over all | ||
/// [`Default`] type. | ||
pub struct FromWorldWrap<T>(pub T); | ||
|
||
macro_rules! impl_from_world { | ||
($($t:ident),*) => { | ||
impl<$($t: FromWorld,)*> FromWorld for FromWorldWrap<($($t,)*)> { | ||
fn from_world(_world: &mut World) -> Self { | ||
FromWorldWrap(($($t::from_world(_world),)*)) | ||
} | ||
} | ||
}; | ||
} | ||
|
||
all_tuples!(impl_from_world, 0, 12, T); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
|
||
struct MainThreadValidator { | ||
main_thread: std::thread::ThreadId, | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather have all all_tuples work on the same maximum number of items in a tuple, so 16. It would be less surprising for users