Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update linux_dependencies.md #7021

Closed
wants to merge 1 commit into from

Conversation

aktaboot
Copy link
Contributor

fixes alsalib dependency for NixOS

fixes alsalib dependency for NixOS
@nicopap
Copy link
Contributor

nicopap commented Dec 24, 2022

I'll admit I'm impressed. That particular line of the docs was modified about 5 times in the last 2 years by supposedly nix users and none noticed it was wrong? Or was it correct and nix recently changed the package name?

Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was deprecated / renamed mid-2021, but an alias was added at the same time.
NixOS/nixpkgs#126440

That alias was removed in september of this year:
NixOS/nixpkgs#192681

@rparrett rparrett added C-Docs An addition or correction to our documentation A-Build-System Related to build systems or continuous integration O-Linux Specific to the Linux desktop operating system labels Dec 24, 2022
@alice-i-cecile
Copy link
Member

Can you change the PR title to be a bit more descriptive? It turns into our commit messages :)

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 25, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 26, 2022
fixes alsalib dependency for NixOS
@bors bors bot changed the title Update linux_dependencies.md [Merged by Bors] - Update linux_dependencies.md Dec 26, 2022
@bors bors bot closed this Dec 26, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
fixes alsalib dependency for NixOS
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
fixes alsalib dependency for NixOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Docs An addition or correction to our documentation O-Linux Specific to the Linux desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants