-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to WGPU 22 #98
Conversation
I haven't ran it locally to check if this is the issue, but the test output tends to change a bit on wgpu/naga upgrades. If it looks functionally the same it's probably fine to just overwrite the failing tests' expected outputs. |
I put up gfx-rs/wgpu#6045 that will be backported and part of the 22.1 release. |
Naga 22.1 has released with PartialEq back on types. |
I've updated some failing tests - to me it looks like just the numbering in the error message is different |
I opened a PR for this with a few fixes and cleanups callym#1 We'll have to update bevy's capabilities detection as well. |
The test failures are assertions that were never hit before because they used |
Oops, I guess I probably should've ran the tests locally when I fixed that. |
I don't think there's any way that check could ever work as the final shader string length is almost always going to be different to the initial string, for example here's one of the outputs: initial shader string: final string after preprocess: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - haven't tested thoroughly but i agree the length check is vestigial, and the rest looks straightforward.
This currently doesn't pass the tests, I think because
naga
removed thePartialEq
implementation on a bunch of types (gfx-rs/wgpu#5818)