Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[naga] add back PartialEq derives for some types #6045

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jul 25, 2024

Reverts #5818 since naga_oil needs these.

Ideally these types shouldn't need PartialEq but the current implementation of naga_oil requires them.
Once we get to #5713 we can revert this PR.

cc @robtfm @stefnotch

@teoxoy teoxoy added the PR: needs back-porting PR with a fix that needs to land on crates label Jul 25, 2024
@teoxoy teoxoy requested a review from a team as a code owner July 25, 2024 09:03
@teoxoy teoxoy removed the PR: needs back-porting PR with a fix that needs to land on crates label Jul 25, 2024
@jimblandy jimblandy merged commit 1f4f675 into gfx-rs:trunk Jul 26, 2024
25 checks passed
@teoxoy teoxoy deleted the rev-5818 branch July 26, 2024 16:42
@teoxoy teoxoy added the PR: needs back-porting PR with a fix that needs to land on crates label Jul 26, 2024
cwfitzgerald pushed a commit to cwfitzgerald/wgpu that referenced this pull request Jul 31, 2024
@Wumpf Wumpf removed the PR: needs back-porting PR with a fix that needs to land on crates label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants