[naga] Remove unneeded PartialEq derivations.
#5818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
naga
Remove `PartialEq` derivations from various Naga IR types on which equality doesn't really make sense. In some cases, derive only in `cfg(test)` builds, so tests can check for expected output. In the GLSL front end, use `append` to add new constants, not `fetch_or_append`, since the latter requires `PartialEq` yet GLSL doesn't permit duplicate declarations anyway.
jimblandy
force-pushed
the
naga-less-PartialEq
branch
from
f5f251e
to
d4be02f
Compare
teoxoy
approved these changes
Jun 17, 2024
mockersf
pushed a commit
to bevyengine/naga_oil
that referenced
this pull request
Aug 3, 2024
This currently doesn't pass the tests, I think because `naga` removed the `PartialEq` implementation on a bunch of types (gfx-rs/wgpu#5818) --------- Co-authored-by: Elabajaba <Elabajaba@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
PartialEqderivations from various Naga IR types on which equality doesn't really make sense. In some cases, derive only incfg(test)builds, so tests can check for expected output.In the GLSL front end, use
appendto add new constants, notfetch_or_append, since the latter requiresPartialEqyet GLSLdoesn't permit duplicate declarations anyway.