Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DiffractometerMixin from apstools #78

Closed
2 tasks done
prjemian opened this issue Dec 22, 2020 · 2 comments · Fixed by #116
Closed
2 tasks done

add DiffractometerMixin from apstools #78

prjemian opened this issue Dec 22, 2020 · 2 comments · Fixed by #116
Assignees
@stuartcampbell @prjemian
Labels
enhancement
Milestone
v0.3.16

Comments

@prjemian
Copy link
Contributor

prjemian commented Dec 22, 2020 •
edited
Loading

The apstools package has a supplementary diffractometer support, including a DiffractometerMixin class. All of this would be a strong addition to the hklpy package.

In apstools, there are open issues to resolve here:

Also, add the Constraint support.
@prjemian prjemian added this to the v0.3.16 milestone Dec 22, 2020
@prjemian prjemian self-assigned this Dec 22, 2020
This was referenced Dec 22, 2020
Closed
Closed
Closed
@prjemian prjemian mentioned this issue Dec 27, 2020
Closed
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
MNT #78 sort the imports, add pyRestTable
a2a32c4
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
MNT #78 add wh() method
7bfc664
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
ENH #78 and FIX #86
2ecd29c
@prjemian prjemian mentioned this issue Dec 27, 2020
Closed
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
WIP #78 add pa() method, apply black -l 75
cf9e81d
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
CI #78 apply black -l 75 to all tests
ecf0b70
@prjemian prjemian mentioned this issue Dec 27, 2020
Closed
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
WIP #78 pa() method
9958040
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
CI #78 remove example table per flake8 (E501)
115a2f8
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
ENH #78 pa() ready
3b91a7f
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
TST #78
8b25cd3
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
ENH #78 add constraints support
d699c2f
prjemian added a commit that referenced this issue Dec 27, 2020
@prjemian
MNT #78 reviews
3031c2a
@prjemian prjemian mentioned this issue Mar 23, 2021
Closed
@prjemian
Copy link
Contributor Author

prjemian commented Apr 17, 2021 •
edited
Loading

The DiffractometerMixin was dropped from apstools in release 1.5.0 (in anticipation of its move to this repo). The URL above was edited to point to the file as it existed in apstools 1.4.1 .

prjemian added a commit that referenced this issue Apr 17, 2021
@prjemian
ENH #78 add wh() reporting method
24be98b
prjemian added a commit that referenced this issue Apr 17, 2021
@prjemian
DOC #78 wh()
2b1a09e
prjemian added a commit that referenced this issue Apr 17, 2021
@prjemian
ENH #78 pa()
9106f09
prjemian added a commit that referenced this issue Apr 17, 2021
@prjemian
ENH #78 forwardSolutionsTable()
de73384
prjemian added a commit that referenced this issue Apr 17, 2021
@prjemian
ENH #78 constraints
0d35f1a
prjemian added a commit that referenced this issue Apr 18, 2021
@prjemian
CI #78 apply black -l 115
220523e
prjemian added a commit that referenced this issue Apr 18, 2021
@prjemian
CI #78
8cada5a
@prjemian
Copy link
Contributor Author

All features from DiffractometerMixin() have been added, including unit tests.

@prjemian prjemian mentioned this issue Apr 18, 2021
Merged
prjemian added a commit that referenced this issue Apr 18, 2021
@prjemian
TST #78 use the higher-level API
d92abf4
prjemian added a commit that referenced this issue Apr 18, 2021
@prjemian
MNT #78 typo
65b2388
prjemian added a commit that referenced this issue Apr 19, 2021
@prjemian
CI #78
cf0506e
prjemian added a commit that referenced this issue Apr 19, 2021
@prjemian
MNT #78 per review suggestion
6ce2560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartcampbell stuartcampbell

@prjemian prjemian

Labels
enhancement
Projects
None yet
Milestone
v0.3.16
2 participants
@stuartcampbell @prjemian