-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additions from apstools #87
Conversation
@mrakitin Ready for review now. |
The new code here will support #63. Simpler examples can be the result. |
I am seeing additions from other, earlier PRs. Probably it would make sense to merge them first, then rebase this PR on |
The goal here was to bring in the user interface first worked out in apstools (#78). While doing that, two other issues (#86 and #88) were exposed. All these relate back to #50. This is a set of issues that work together. This PR lays foundation for the final work on #50 (to be completed after this PR is merged). |
@mrakitin Thanks for the suggestions. Evidence is building for a restart on this effort, taking it in pieces (multiple issues, merge conflicts, other PRs that could affect). I'll look at new branches+PRs for the separate issues. Not closing here. Not yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections to merge it.
Oh, please disregard my approval, as #116 replaces this PR. Can we close this PR without merging then? |
Right. This PR (and another one from January, #89) has been labeled |
And, PR #116 was just merged. |
Add reports from the apstools DiffractometerMixin directly to the Diffractometer class.
Fix #78
Also, fix #86 where Diffractometer.energy did not respond to changes to energy units and/or offset.
Also add Components for geometry_name and class_name (fix #88) so they are recorded with data to enable recovery of UB (#50) from previous runs and resume scanning.