add features from apstools.DiffractometerMixin() #116

prjemian · 2021-04-18T03:08:52Z

Fix #78 (replaces #87)

prjemian · 2021-04-18T03:09:27Z

@mrakitin - This is ready for review.

mrakitin

Looks good, thanks @prjemian. I haven't given it a very detailed reading but only have a style suggestion.

hkl/diffract.py

prjemian added 7 commits April 17, 2021 16:30

ENH #78 add wh() reporting method

24be98b

DOC #78 wh()

2b1a09e

ENH #78 pa()

9106f09

ENH #78 forwardSolutionsTable()

de73384

ENH #78 constraints

0d35f1a

CI #78 apply black -l 115

220523e

CI #78

8cada5a

prjemian added the enhancement label Apr 18, 2021

prjemian added this to the v0.3.16 milestone Apr 18, 2021

prjemian requested a review from mrakitin April 18, 2021 03:08

prjemian self-assigned this Apr 18, 2021

prjemian mentioned this pull request Apr 18, 2021

provide SPEC-compatibility functions from APS 29-ID #63

Closed

prjemian added 3 commits April 18, 2021 11:38

TST #78 use the higher-level API

d92abf4

MNT #78 typo

65b2388

CI #78

cf0506e

mrakitin mentioned this pull request Apr 19, 2021

additions from apstools #87

Closed

mrakitin approved these changes Apr 19, 2021

View reviewed changes

hkl/diffract.py Outdated Show resolved Hide resolved

MNT #78 per review suggestion

6ce2560

prjemian merged commit e9ad35e into main Apr 19, 2021

prjemian deleted the 78-DiffractometerMixin branch April 19, 2021 13:56

prjemian added a commit that referenced this pull request Apr 19, 2021

MNT #63 per #116

dc0679b

Provide feedback