Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 0.4.0 #103

Merged
merged 56 commits into from
Dec 30, 2022
Merged

Release - 0.4.0 #103

merged 56 commits into from
Dec 30, 2022

Conversation

blyscuit
Copy link
Owner

blyscuit and others added 30 commits December 7, 2022 17:22
@blyscuit
[Chore] Update iOS to 0.4.0
2d36f7d
@blyscuit
Merge pull request #87 from blyscuit/chore/bump-version-0.4.0
dcc6aad 
[Chore] Bump version to 0.4.0
@blyscuit
[#74] Add TokenizedNetworkClient
8b1090b
@blyscuit
[#74] Refactor tests
16a9fbb
@blyscuit
[#74] Add Turbine for test
78b7795
@blyscuit
[#18] Add SurveyRepository
1c95819
@blyscuit
[#18] Add SurveyUseCase test
431ea90
@blyscuit
[#18] Add Napier, fix network call on the wrong client
2f96ed0
@blyscuit
[#18] Rebase
2aa2e61
@blyscuit
[#18] Fix PR comments, rename data files
baf48bd
@blyscuit
[#74] Private and remove redundant self
b25354d
@blyscuit
Merge pull request #78 from blyscuit/feature/#74-api-access-token
b5ccc86 
[#74] [KMM] [Backend] As a user, I can call api with access token
@blyscuit
Merge pull request #79 from blyscuit/feature/#18-survey-backend
4a333c0 
[#18] [KMM] [Backend] As a user, I can see Survey selection page
@blyscuit
[#10] Integrate login viewmodel
5e373b4
@blyscuit
[#10] Integrate login viewmodel
308caf5
@blyscuit
[#10] Integrate login viewmodel
e89b62a
@blyscuit
[#10] Integrate login viewmodel
2fa3271
@blyscuit
[#10] Add StateObject coordinator injection
4bacb73
@blyscuit
[#10] Add interruption to fix random crash
8649c99
@blyscuit
[#10] Fix lint
e92e175
@blyscuit
[#10] Fix PR comments
d403c28
@blyscuit
Test Danger Lint
c3a1da0
@blyscuit
Force fail
3ef23f4
@blyscuit
Test Danger Lint
420495c
@blyscuit
Test Danger Lint
cfcc15b
@blyscuit
Update .swiftlint.yml
9faa336
@blyscuit
[Chore] Add Test plan
bebd123
@blyscuit
[Chore] Fix Danger
d14d1e3
@blyscuit
[Chore] Add test scheme
087a20b
@blyscuit
Merge pull request #97 from blyscuit/chore/test-plan
bd823bc 
[Chore] Add Test Plan
@blyscuit blyscuit added this to the 0.4.0 milestone Dec 29, 2022
@blyscuit blyscuit requested a review from suho as a code owner December 29, 2022 05:03
@blyscuit blyscuit self-assigned this Dec 29, 2022
@github-actions
Copy link

github-actions bot commented Dec 29, 2022 •
edited
Loading

8 Warnings
⚠️ Big PR
⚠️ Uh oh! NetworkClient.kt is under 95% coverage!
⚠️ Uh oh! PaginationMetaApiModel.kt is under 95% coverage!
⚠️ Uh oh! ResetPasswordTargetType.kt is under 95% coverage!
⚠️ Uh oh! SharedBuildConfig.kt is under 95% coverage!
⚠️ Uh oh! SurveyApiModel.kt is under 95% coverage!
⚠️ Uh oh! SurveySelectionTargetType.kt is under 95% coverage!
⚠️ Uh oh! UserApiModel.kt is under 95% coverage!

🧛 shared Code Coverage: 81.09%

Coverage of Modified Files:

File Coverage
ApiPath.kt 100.00%
AuthenticationRepositoryImpl.kt 100.00%
CheckLoginUseCase.kt 100.00%
DelayFlowOf.kt 100.00%
DeviceInfoRepositoryImpl.kt 100.00%
GetCurrentDateUseCase.kt 100.00%
GetProfileUseCase.kt 100.00%
LoginViewModel.kt 96.50%
NetworkClient.kt 47.19%
NetworkDataSource.kt 100.00%
PaginationMeta.kt 100.00%
PaginationMetaApiModel.kt 81.82%
ResetPasswordTargetType.kt 58.53%
SharedBuildConfig.kt 0.00%
SplashViewModel.kt 100.00%
String+Regex.kt 95.83%
SurveyApiModel.kt 80.20%
SurveyHeaderUiModel.kt 100.00%
SurveyListUseCase.kt 100.00%
SurveyRepositoryImpl.kt 100.00%
SurveySelectionTargetType.kt 64.62%
SurveySelectionViewModel.kt 100.00%
TargetType.kt 100.00%
TokenizedNetworkClient.kt 96.33%
User.kt 100.00%
UserApiModel.kt 80.61%
UserProfileTargetType.kt 100.00%
UserRepositoryImpl.kt 100.00%

Modified Files Not Found In Coverage Report:

.swiftlint.yml
.swiftlint.yml
.swiftlint.yml
AccountRecoveryRepositoryTest.kt
AnyFlow.kt
AppCoordinator.swift
AppDelegate.swift
ArgumentedXCUIApplication.swift
AuthenticationRepository.kt
AuthenticationRepositoryTest.kt
CICDTests.xctestplan
CheckLoginUseCaseTest.kt
Combine+Collect.swift
Constants.rb
Dangerfile
DataStoreTest.kt
DateFormat.kt
DateFormatter.kt
DateFormatterTest.kt
DateTimeFormatter.kt
DateTimeFormatterImpl.kt
DateTimeFormatterImpl.kt
DateTimeFormatterTest.kt
Dependency.kt
DeviceInfoRepository.kt
DeviceInfoRepositoryTest.kt
DomainHelperModule.kt
ErrorJsonResult.kt
Fastfile
GetCurrentDateUseCaseTest.kt
GetProfileUseCaseTest.kt
IosGreetingTest.kt
JsonMockEngine.kt
JsonTokenizedMockEngine.kt
Koin+Constants.kt
Koin.kt
KoinApplication.swift
LaunchArgument.swift
LocalDataSourceTest.kt
LogInUseCaseTest.kt
LoginFlow.swift
LoginScreen.swift
LoginSpec.swift
LoginView+DataSource.swift
LoginView.swift
LoginViewDataSourceSpec.swift
LoginViewModelTest.kt
MokoLocalizeTest.kt
NetworkClientTest.kt
NetworkDataSourceTest.kt
NetworkMetaMockModel.kt
NetworkModule.kt
NotificationManagerSpec.swift
PrimaryTextField.swift
RepositoryModule.kt
ResetPasswordSpec.swift
ResetPasswordUseCaseTest.kt
ResetPasswordViewDataSourceSpec.swift
ResetPasswordViewModelTest.kt
RouteCoordinator.swift
Screen.swift
ScreenProtocol.swift
Shared+AutoMockable.swift
SplashView+DataSource.swift
SplashView.swift
SplashViewDataSourceSpec.swift
SplashViewModelTest.kt
Start.kt
StringRegexTest.kt
Survey Staging Extended Tests.xcscheme
Survey Staging.xcscheme
SurveyHeaderView.swift
SurveyListJsonResult.kt
SurveyListUseCaseTest.kt
SurveyLoading.swift
SurveyLoadingScreen.swift
SurveyRepository.kt
SurveyRepositoryTest.kt
SurveySelectionSpec.swift
SurveySelectionView+DataSource.swift
SurveySelectionView.swift
SurveySelectionViewDataSourceSpec.swift
SurveySelectionViewModelTest.kt
TestManager.rb
TimeInterval+Constants.swift
TokenizedNetworkClientTest.kt
UITestHelper.swift
UITestLogout.kt
UseCaseModule.kt
UserProfileJsonResult.kt
UserRepository.kt
UserRepositoryTest.kt
UserTargetType.kt
Versions.kt
ViewDidLoadModifier.swift
ViewModelModule.kt
XCTestCase+PermissionInteruption.swift
build.gradle.kts
contents.xcworkspacedata
ios_sanity_full_test.yml
project.pbxproj
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Dec 29, 2022 •
edited
Loading

Current coverage for Survey is 82.01%

Files changed - -
KoinApplication.swift 33.33% 🚫
LaunchArgument.swift 50.00% ⚠️
RouteCoordinator.swift 62.50% ⚠️
AppDelegate.swift 66.67% ⚠️
SurveySelectionView+DataSource.swift 87.10% ✅
LoginView+DataSource.swift 90.24% ✅
SplashView+DataSource.swift 91.49% ✅
UITestHelper.swift 93.18% ✅
PrimaryTextField.swift 93.55% ✅
LoginView.swift 95.16% ✅
SurveySelectionView.swift 96.73% ✅
ViewDidLoadModifier.swift 100.00% ✅
SurveyLoading.swift 100.00% ✅
SurveyHeaderView.swift 100.00% ✅
AppCoordinator.swift 100.00% ✅
SplashView.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

minhnimble
minhnimble approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@blyscuit
Merge pull request #93 from blyscuit/feature/#21-home-header-backend
0c8f5e2 
[#21] [KMM] [Backend] As a user, I can see Survey header
@blyscuit
Merge pull request #94 from blyscuit/feature/#22-home-header-viewmodel
241a315 
[#22] [iOS] [Integrate] As a user, I can see Survey header
@blyscuit blyscuit merged commit b2ed0ff into main Dec 30, 2022
@blyscuit blyscuit deleted the release/0.4.0 branch December 30, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doannimble doannimble doannimble approved these changes

@minhnimble minhnimble minhnimble approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@edgarss edgarss Awaiting requested review from edgarss edgarss is a code owner

Assignees

@blyscuit blyscuit

Labels
type: release
Projects
KMM IC
Status: Done
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blyscuit @minhnimble @doannimble