Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 0.8.0 #131

Merged
merged 18 commits into from
Mar 9, 2023
Merged

Release - 0.8.0 #131

merged 18 commits into from
Mar 9, 2023

Conversation

@blyscuit blyscuit added this to the 0.8.0 milestone Mar 7, 2023
@blyscuit blyscuit self-assigned this Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

7 Warnings
⚠️ Big PR
⚠️ Uh oh! NetworkClient.kt is under 95% coverage!
⚠️ Uh oh! SubmitSurveyTargetType.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ shared/build/generated/moko/androidMain/res/values/colors.xml#L3 - The resource R.color.backgroundColor appears to be unused
⚠️ shared/build/generated/moko/androidMain/res/values/colors.xml#L4 - The resource R.color.primary appears to be unused
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/data/network/core/TokenizedNetworkClient.kt#L47 - The function bearerConfig is too long (21). The maximum length is 20.

🧛 shared Code Coverage: 79.66%

Coverage of Modified Files:

File Coverage
NetworkClient.kt 56.12%
NetworkDataSource.kt 100.00%
SubmitSurveyTargetType.kt 35.91%
SubmitSurveyUseCase.kt 100.00%
SurveyDetailDummy.kt 100.00%
SurveyDetailViewModel.kt 97.65%
SurveyQuestionViewState.kt 100.00%
SurveyRepositoryImpl.kt 100.00%
SurveySelectionViewModel.kt 96.83%
SurveySubmission.kt 100.00%
SurveySubmissionUiModel.kt 100.00%

Modified Files Not Found In Coverage Report:

AA_AppLoadSpec.swift
ColorResource+Color.swift
Dependency.kt
LottieView.swift
NetworkClientTest.kt
NetworkDataSourceTest.kt
Podfile
Podfile.lock
QuestionEmojiView.swift
QuestionMultiChoiceView.swift
QuestionMultiFormView.swift
QuestionPickerView.swift
QuestionRangePickerView.swift
QuestionTextAreaView.swift
RouteCoordinator.swift
RouterCoordinator+WithoutAnimation.swift
SubmissionSuccessScreen.swift
SubmissionSuccessSpec.swift
SubmissionSuccessView.swift
SubmitSurveyUseCaseTest.kt
SurveyDetailView+DataSource.swift
SurveyDetailView.swift
SurveyDetailViewModelTest.kt
SurveyQuestionScreen.swift
SurveyQuestionView.swift
SurveyRepository.kt
SurveyRepositoryTest.kt
UseCaseModule.kt
Versions.kt
ViewId+SubmissionSuccess.swift
ViewId+SurveyDetail.swift
ViewId.swift
ViewModelModule.kt
build.gradle.kts
colors.xml
confetti.json
project.pbxproj
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Current coverage for Survey is 82.03%

Files changed - -
QuestionPickerView.swift 0.00% 💀
RouteCoordinator.swift 85.37%
QuestionEmojiView.swift 89.19%
QuestionMultiChoiceView.swift 89.36%
SurveyQuestionView.swift 89.58%
QuestionTextAreaView.swift 90.91%
QuestionMultiFormView.swift 92.31%
LottieView.swift 94.44%
QuestionRangePickerView.swift 96.57%
SurveyDetailView.swift 96.91%
SurveyDetailView+DataSource.swift 100.00%
RouterCoordinator+WithoutAnimation.swift 100.00%
SubmissionSuccessView.swift 100.00%
ColorResource+Color.swift 100.00%
ViewId.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit changed the title Release/0.8.0 Release - 0.8.0 Mar 7, 2023
[#41] [Integrate] As a user, I can submit my form
@blyscuit blyscuit force-pushed the release/0.8.0 branch 2 times, most recently from aea756b to 3a17a40 Compare March 7, 2023 12:26
@blyscuit blyscuit marked this pull request as ready for review March 7, 2023 12:26
@blyscuit blyscuit requested a review from doannimble as a code owner March 7, 2023 12:26
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@blyscuit blyscuit merged commit 9de255a into main Mar 9, 2023
@blyscuit blyscuit deleted the release/0.8.0 branch March 9, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants