Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TypeError: BpmnModdle is not a constructor #30

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

corocoto
Copy link
Contributor

Description:

This PR updates bpmn-moddle package to the latest version. And refactors the cleanDI function at the test file and AutoLayout's layoutProcess method.

Related issues:

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution.

Will release as a major.

@nikku nikku merged commit b4efbd0 into bpmn-io:master Mar 24, 2023
@corocoto
Copy link
Contributor Author

corocoto commented Mar 30, 2023

@nikku, excuse me, but could you release this library in the nearest days? Because I want to use its new version for my project. And another good point is that we can close old related issues.

Thanks!

[UPD] Ahh, sorry. I think we shouldn't release the library right now. Because I again met with the same issue. I suppose I can fix it. Anyway, I'll try to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants