Updates codebase from commonjs to es-modules syntax #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates mocha package to the latest version (it needs to work with es modules)
corocoto
commented
May 20, 2023
| @@ -32,7 +33,7 @@ | |||
| "devDependencies": { | |||
| "eslint": "^6.7.2", | |||
| "eslint-plugin-bpmn-io": "^0.10.0", | |||
| "mocha": "^6.2.2", | |||
| "mocha": "^10.2.0", | |||
There was a problem hiding this comment.
Updating to the latest version was neccessary to correctly work with es-modules syntax
corocoto
changed the title
|
Looks good to me. |
nikku
reviewed
May 22, 2023
nikku
approved these changes
May 22, 2023
|
Released Great job! 🎉 |
|
@nikku, cool! Thanks for your kind words! And thanks a lot for your help 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should resolve the "TypeError: BpmnModdle is not a constructor" error. And should be consistent solution as for Node.js as for browser environment.
Related PRs:
Related issues: