Fix: TypeError: BpmnModdle is not a constructor (at work with es modules)

[corocoto]

Description

I met with this error again, when using es modules. To fix this problem, I decided to use 'OR' condition to get truly BpmnModdle class for both available types (commonjs, es modules). I believe that this PR fully closes and resolves the BpmnModdle is not a constructor error.

Related PRs:

• Fix: TypeError: BpmnModdle is not a constructor #30

Related issues:

• TypeError: BpmnModdle is not a constructor #18
• Module does not work in react #22

[nikku]

I met with this error again, when using es modules. To fix this problem, I decided to use 'OR' condition to get truly BpmnModdle class for both available types (commonjs, es modules). I believe that this PR fully closes and resolves the BpmnModdle is not a constructor error.

How do you try to consume this library?

I think we want to settle on a library target (is this ES or CJS modules), clean this up, and potentially provide a pre-built distribution for it (that works independent of the usage context).

You'll likely run into troubles otherwise, depending how you include things.

[corocoto]

How do you try to consume this library?

I transform input JSON data, received from the backend side, to the BPMN object. After the previous step, I continue to construct the BPMN structure by adding DI elements and their own positions and sizes. In the end, I display the result on the page.

[corocoto]

I think we want to settle on a library target (is this ES or CJS modules), clean this up, and potentially provide a pre-built distribution for it (that works independent of the usage context).

You'll likely run into troubles otherwise, depending how you include things.

Hm, you're right, @nikku. I think it's the correct view of things. So, after our discussion, I decided to close this PR, because it became irrelevant.

[nikku]

#31 (comment)

From ES or CJS context? In the browser or in NodeJS?

[corocoto]

@nikku, from ES context (in the browser environment)

[nikku]

@corocoto Unfortunately we were not able to follow up on this PR on time. We'll close this for the time being and hope that we can revive this project some time in the future.