set kDesktopSharingHubEnabled to true but hide/remove Share link to section

[rebron]

Description

Add Desktop sharing hub but hide or remove share link section

Actual result:

In current release, 1.44.112 and lower -

Shows only QR code icon

Visit any website and click on url bar and notice QR code icon. Selection of QR code icon will show a QR code for the website.

Expected result:

1. Screen 1 - Default menu

2. Screen 2 - Menu with sync enabled Send to your Devices

3. Screen 3 - Menu with cast enabled

4. Screen 4 - Menu with all enabled.

Test Plan

New Profile

1. Use version 1.45.112 or higher.
2. Create a new profile, go to any website and enter url bar. Notice share icon in Expected result screen 1.
3. Ensure that you can a) copy link, b) copy clean link, c) create a QR code and d) save page as to your computer.

Profile with Sync enabled

1. Use version 1.45.112 or higher
2. Use a profile that has sync enabled. Go to any website and enter url bar. Notice share icon menu in Expected result screen 2 and ensure Send to your Devices is listed.
3. Ensure that you can Share to devices by selecting Send to your Devices and choosing the device to share to.

Profile with Cast enabled

1. Use version 1.45.112 or higher.
2. Use a profile that has Cast enabled by going to brave://settings/extensions and enabling Media Router. Relaunch after turning on. Notice share icon menu in Expected result screen 3 and ensure Cast... is listed in the menu.
3. Ensure that you can Cast the page to your casting device/tv.

Profile with Cast and Sync enabled.

1. Ensure what's listed in screen 4 displays after steps from Profile with Sync enabled and Profile with Cast enabled.

Brave version (brave://version info)

Target release 1.45.x

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issues:
#20757
#25621

[kjozwiak]

The above requires 1.45.112 or higher for 1.45.x verification 👍

[MadhaviSeelam]

Verification PASSED using

Brave | 1.45.112 Chromium: 107.0.5304.62 (Official Build) (64-bit)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Test Case 1: New Profile - PASSED

Case 1: Share this page icon visible in the URL bar

• Install 1.45.112
• launch Brave
• visit a site (github.com)

Confirmed Share this page icon in the URL bar left to Shields icon

Case 2: Share this page options functionality

1. continue from Case 1
2. click dShare this page icon
3. confirmed all four options displayed

• a) Copy link
• b) Copy clean link
• c) Create a QR code
• d) Save page as

step 3

copy link

Ex1	Ex2

copy clean link

Ex1	Ex2

QR code

Ex1	Ex2	Ex3	Ex4

Save page as

Ex1	Ex2	Ex3

Test Case 2: Profile with Sync enabled - PASSED

1. New profile
2. launched Brave on Desktop Device 1
3. opened brave://sync-->start a new Sync Chain
4. copy the sync chain code
5. selected Sync everything in the Sync settings
6. launched Brave on Desktop Device 2
7. opened brave://sync-->I have a Sync code
8. paste the code-->Confirm-->Ok
9. visit https://cnn.com on Desktop Device 1
10. click Share this page icon
11. confirmed Send to your Devices is listed in the options
12. clicked Send to your Devices
13. clicked on the device name Brave
14. Desktop Device 2 shows Page shared from another device message
15. clicked Open in the New Tab button to show same page

step 3	step 6	step 11	step 12	step 13	step14	step 15

Test Case 3: Profile with Cast enabled - PASSED

1. new profile
2. open brave://settings/extensions
3. toggle ON for Media Router
4. click Relaunch
5. Share this page icon was visible on the URL
6. click on Share this page icon to view Cast... is listed

Confirmed I was able to successfully Cast the page to casting device i.e. TV

step 4	step5	step6

Test Case 4: Profile with Cast and Sync enabled - PASSED

1. continue from Test Case 2
2. Sync is still enabled with Send to your Devices on Desktop Device 1
3. open brave://settings/extensions
4. toggle ON for Media Router
5. click Relaunch
6. visit a website URL (https://www.bbc.com/travel/article/20220929-new-zealands-overlooked-indigenous-cuisine)
7. click Share this page icon in the URL
8. confirmed Cast and Send to your devices options are listed
9. click on Cast to successfully Cast to a device i.e TV
10. click on Send to you devices
11. Sync enabled Desktop Device 2 shows the Page shared from another device dialog
12. clicked Open in New Tab to show same page

step 4	step 8	step 9	step 10	step 11	step 12

[stephendonner]

Verification PASSED using

Brave	1.45.112 Chromium: 107.0.5304.62 (Official Build) (x86_64)
Revision	1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS	macOS Version 11.7 (Build 20G817)

Case 1: New profile - PASSED

1. installed 1.45.112
2. launched Brave
3. loaded https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
4. clicked on the Share this page icon in the URL bar
5. ensured each of the following options worked:

• Copy link
• Copy clean link
• Create QR Code
• Save page as...

Copy link

Chose Copy link and confirmed I got the full URL:

https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end

Copy clean link

Chose Copy clean link and confirmed I got the cleaned URL:

https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end

Create QR Code

Chose Create QR Code and confirmed I could scan & load brave.com on Android:

QR Code	brave.com loaded

Save page as...

Chose Save page as... and confirmed I could open the saved contents (without relative-pathed images)

brave.com	local brave.com

Case 2: Profile with Sync enabled - PASSED

1. installed 1.45.112
2. launched Brave
3. opened brave://sync
4. set up a sync chain
5. joined the sync chain from Android
6. back on desktop, loaded brave.com
7. clicked on the Share this page icon in the URL bar
8. selected Send to Your devices
9. chose Google phone
10. checked my Android (Google Pixel XL)

Confirmed my Pixel XL received a notification about the sent brave.com link

QR Code	brave://sync	Send to Your Devices	Google phone	Sending...	Android

Case 3: Profile with Cast enabled - PASSED

installed 1.45.112
loaded youtube.com
clicked on the Share this page icon in the URL bar
looked at the list of devices

Confirmed I was able to list all of my (otherwise?) Cast-enabled devices

brave://extensions	list of (Cast-able) devices

Case 4: Profile with Sync and Cast enabled - PASSED

Send to Your Devices	Cast...

[btlechowski]

Verification passed on

Brave	1.45.113 Chromium: 107.0.5304.62 (Official Build) (64-bit)
Revision	1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS	Ubuntu 18.04 LTS

Case 1: New profile - PASSED

1. installed 1.45.113
2. launched Brave
3. loaded https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
4. clicked on the Share this page icon in the URL bar
5. ensured each of the following options worked:

• Copy link
• Copy clean link
• Create QR Code
• Save page as...

Copy link

Chose Copy link and confirmed I got the full URL:

https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end

Copy clean link

Chose Copy clean link and confirmed I got the cleaned URL:

https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end

Create QR Code

Chose Create QR Code and confirmed I could scan & load brave.com on iphone:

QR Code	brave.com loaded

Save page as...

Chose Save page as... and confirmed I could open the saved contents (without relative-pathed images)

Case 2: Profile with Sync enabled - PASSED

1. installed 1.45.113
2. launched Brave
3. opened brave://sync
4. set up a sync chain
5. joined the sync chain from Android
6. back on desktop, loaded brave.com
7. clicked on the Share this page icon in the URL bar
8. selected Send to Your devices
9. chose iphone
10. checked my iphone

Confirmed my iphone received a notification about the sent brave.com link

Case 3: Profile with Cast enabled - PASSED

installed 1.45.113
loaded youtube.com
clicked on the Share this page icon in the URL bar
looked at the list of devices

Confirmed I was able to list all of my (otherwise?) Cast-enabled devices

Case 4: Profile with Sync and Cast enabled - PASSED

[kjozwiak]

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.45.113 Chromium: 107.0.5304.62 (Official Build) (64-bit)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Windows 11 Version 22H2 (Build 22621.675)

Verified that Cast was working without any issues via the new enabled Share hub by casting from my PC running 1.45.113 Chromium: 107.0.5304.62 to a TV downstairs that's connected to an Nvidia Shield that has casting enabled:

• installed 1.45.113 Chromium: 107.0.5304.62
• enabled Media Router via brave://settings/extensions
• once enabled, visited https://www.yoursoccerdose.com/matches/18535289/west-ham-united-vs-afc-bournemouth
• clicked on a video and ensured that Cast appeared under the Share hub via the URL bar
• ensured that clicking on Cast opened the Cast menu with all the available devices on the network that can cast
• picked the Nvidia shield in the living room and ensured you can cast both the Window & Tab

Example	Example	Example	Example	Example