Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sharing hub on all channels w/o third party actions (uplift to 1.45.x). #15629

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#26019
Uplift from #15479

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Enable sharing hub on all channels w/o third party actions
@mkarolin mkarolin self-assigned this Oct 24, 2022
@mkarolin mkarolin requested a review from a team as a code owner October 24, 2022 16:42
@kjozwiak kjozwiak added this to the 1.45.x - Release milestone Oct 24, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍

@kjozwiak kjozwiak merged commit 4e3fbd9 into 1.45.x Oct 24, 2022
@kjozwiak kjozwiak deleted the maxk-sharing_hub-1.45.x branch October 24, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants