-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sharing hub on all channels w/o third party actions #15479
Conversation
28fee34
to
d27b83d
Compare
view->SetGroup(kActionButtonGroup); | ||
} | ||
|
||
+ BRAVE_SHARING_HUB_BUBBLE_VIEW_IMPL_POPULATE_SCROLL_VIEW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible, maybe we can use this?
BraveSharingHubBubbleViewImpl::PopulateScrollView() {
SharingHubBubbleViewImpl::PopulateScrollView();
if (share_link_label_) {
action_list_view->RemoveChildView(share_link_label_);
MaybeSizeToContents();
Layout();
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think it's difficult with subclass because we should also remove below separator view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but if possible to replace the patch with an override, would be great.
d27b83d
to
9816345
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Enable sharing hub on all channels w/o third party actions
Resolves brave/brave-browser#26019
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
BraveSharingHubTest.SharingHubThirdPartyActionsEmptyTest
See the linked issue for manual test