Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sharing hub on all channels w/o third party actions #15479

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 17, 2022

Resolves brave/brave-browser#26019

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

BraveSharingHubTest.SharingHubThirdPartyActionsEmptyTest

See the linked issue for manual test

@simonhong simonhong requested review from a team as code owners October 17, 2022 02:39
@simonhong simonhong changed the title Sharing hub Enable sharing hub on all channels w/o third party actions Oct 17, 2022
browser/sharing_hub/brave_sharing_hub_model.cc Outdated Show resolved Hide resolved
view->SetGroup(kActionButtonGroup);
}

+ BRAVE_SHARING_HUB_BUBBLE_VIEW_IMPL_POPULATE_SCROLL_VIEW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, maybe we can use this?

BraveSharingHubBubbleViewImpl::PopulateScrollView() {
  SharingHubBubbleViewImpl::PopulateScrollView();
  if (share_link_label_) {
    action_list_view->RemoveChildView(share_link_label_);
    MaybeSizeToContents();
    Layout();
  }
}

Copy link
Member Author

@simonhong simonhong Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think it's difficult with subclass because we should also remove below separator view.

Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but if possible to replace the patch with an override, would be great.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong simonhong merged commit 904963e into master Oct 18, 2022
@simonhong simonhong deleted the sharing_hub branch October 18, 2022 00:57
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 18, 2022
simonhong added a commit that referenced this pull request Oct 18, 2022
mkarolin pushed a commit that referenced this pull request Oct 24, 2022
Enable sharing hub on all channels w/o third party actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set kDesktopSharingHubEnabled to true but hide/remove Share link to section
3 participants