Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards opt in needs a ToS link as part of opt in #3124

Closed
mandar-brave opened this issue Jan 28, 2019 · 4 comments · Fixed by brave/brave-core#2136
Closed

Rewards opt in needs a ToS link as part of opt in #3124

mandar-brave opened this issue Jan 28, 2019 · 4 comments · Fixed by brave/brave-core#2136
Assignees
@ryanml
Labels
feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.65.x - Release ...

Comments

@mandar-brave
Copy link

When a new user opts in to Brave Rewards, the ToS should be made available as part of the opt in process.

@jenn-rhim please add mock for how the ToS and needed text should be place at opt in.
@NejcZdovc - part of the Brave Rewards spec review flow.
@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 28, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 28, 2019
@mandar-brave
Copy link
Author

mandar-brave commented Feb 5, 2019 •
edited
Loading

Three separate use cases to resolve;
screen shot 2019-02-04 at 2 51 52 pm

br off

@NejcZdovc
Copy link
Contributor

@mandar-brave what is the use case for the first screen?

@NejcZdovc
Copy link
Contributor

for setting page

image

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 7, 2019
@ryanml ryanml self-assigned this Apr 1, 2019
@ryanml ryanml mentioned this issue Apr 2, 2019
Merged
9 tasks
@ryanml ryanml added this to the 0.65.x - Nightly milestone Apr 2, 2019
@ryanml ryanml mentioned this issue Apr 2, 2019
Merged
19 tasks
ryanml added a commit to brave/brave-core that referenced this issue Apr 2, 2019
@ryanml
Fixes brave/brave-browser#3124, adds TOS modules to Rewards OptIn points
8064d4b
ryanml added a commit to brave/brave-core that referenced this issue Apr 8, 2019
@ryanml
Fixes brave/brave-browser#3124, adds TOS modules to Rewards OptIn points
5fabb98
@ryanml ryanml modified the milestones: 0.65.x - Nightly, 0.64.x - Dev Apr 8, 2019
@ryanml ryanml mentioned this issue Apr 8, 2019
Closed
3 tasks
pilgrim-brave pushed a commit to brave/brave-core that referenced this issue Apr 16, 2019
@ryanml @pilgrim-brave
Fixes brave/brave-browser#3124, adds TOS modules to Rewards OptIn points
e40914e
This was referenced May 10, 2019
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue May 17, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented May 17, 2019 •
edited by btlechowski
Loading

Verified passed with:

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

@LaurenWags LaurenWags mentioned this issue May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds TOS modules to Rewards Opt-In points brave/brave-core
6 participants
@rebron @ryanml @NejcZdovc @LaurenWags @btlechowski @mandar-brave