This repository has been archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 136
Adding new TOS to Rewards UI Opt-In points #440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
NejcZdovc
reviewed
Apr 2, 2019
ryanml
force-pushed
the
rewards-tos
branch
2 times, most recently
from
April 2, 2019 20:32
61c42d3
to
bd9f9b1
Compare
NejcZdovc
reviewed
Apr 5, 2019
NejcZdovc
approved these changes
Apr 8, 2019
ryanml
added a commit
that referenced
this pull request
Apr 8, 2019
Adding new TOS to Rewards UI Opt-In points
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: brave/brave-browser#3124
This adds block of TOS copy to the points Rewards can be opted in to specified in the issue. This also adds a new component called
DisabledBox
.With the Pre-Opt-In rewards panel, some padding from the design was reduced to respect vertical height.
Welcome Page:
Pre-Opt-In Panel:
Rewards Setting Page (With new component)
Welcome Page Header:
Changes
Test plan
Link / storybook path to visual changes
https://brave-ui-klmmryl7y.now.sh
Integration
Does this contain changes to src/components or src/
Does this contain changes to src/features for brave-core?