-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications are not shown from the background #4199
Labels
Milestone
Comments
Verification passed on
Verification passed with
|
We'll need to retest this once brave/brave-core#2318 lands into |
NejcZdovc
changed the title
Browser tests are failing
Notifications are not shown from the background
Apr 23, 2019
Verification passed on
Used test plan from brave/brave-core#2318. Enabled rewards from panel and brave/brave-core#1365 is blocked on Linux due to #4202 Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This PR broke browser tests brave/brave-core#2296. We need to fix it.
What is happening under the hood is basically observers are not triggered, meaning that user will only get notification when they click on the BAT logo. They will not get notification from the background.
The text was updated successfully, but these errors were encountered: