-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Brave Ads launch notification for existing Rewards users #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f627fb6
to
c208d97
Compare
ryanml
commented
Jan 17, 2019
components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx
Outdated
Show resolved
Hide resolved
ryanml
commented
Jan 17, 2019
components/brave_rewards/resources/extension/brave_rewards/components/panel.tsx
Show resolved
Hide resolved
ryanml
commented
Jan 17, 2019
bridiver
reviewed
Jan 17, 2019
bridiver
reviewed
Jan 17, 2019
bridiver
reviewed
Jan 17, 2019
@bridiver naming updates made |
161c15a
to
94ed386
Compare
bridiver
reviewed
Jan 18, 2019
tmancey
approved these changes
Apr 20, 2019
NejcZdovc
added a commit
that referenced
this pull request
Apr 20, 2019
Revert "Merge pull request #1365 from brave/fix-2914-2"
NejcZdovc
pushed a commit
that referenced
this pull request
Apr 20, 2019
Adds Brave Ads launch notification for existing Rewards users
28 tasks
tmancey
pushed a commit
that referenced
this pull request
Apr 21, 2019
tmancey
pushed a commit
that referenced
this pull request
Apr 22, 2019
tmancey
pushed a commit
that referenced
this pull request
Apr 22, 2019
tmancey
pushed a commit
that referenced
this pull request
Apr 22, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#2914
UI PR: brave/brave-ui#346
Note: This is only intended to be shown to existing users of Rewards who have not enabled Ads yet
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
<0.63
version of Brave to create a profile.Brave-Browser-Development
--brave-ads-debug
as a flag, this reduces the time to delete notification from 7 days to 5 mins) and start Bravebrave://rewards
and dismisses the notification. (Note this will just navigate to the page, it will not automatically enable Ads)Run through the above steps again, except after step 2, disable Rewards before copying the profile. Ensure that when upgrading the notification is not shown.
Also, test this with a clean profile. Opt-in to Rewards, confirm that you don't get the notification (opting in enables ads)
Reviewer Checklist:
cc: @mandar-brave @jsecretan