Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes browser tests #2315

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fixes browser tests #2315

merged 1 commit into from
Apr 23, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 23, 2019

Resolves brave/brave-browser#4199

Submitter Checklist:

Test Plan:

check in #1365

Plan 2:

  • enable rewards (on staging)
  • make sure that you get notification for the grant without clicking on the bat logo

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.66.x - Nightly milestone Apr 23, 2019
@NejcZdovc NejcZdovc requested review from tmancey and ryanml April 23, 2019 09:28
@NejcZdovc NejcZdovc self-assigned this Apr 23, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications are not shown from the background
3 participants