Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset address text is not legible #9236

Closed
srirambv opened this issue Apr 15, 2020 · 2 comments · Fixed by brave/brave-core#5263
Closed

Asset address text is not legible #9236

srirambv opened this issue Apr 15, 2020 · 2 comments · Fixed by brave/brave-core#5263
Assignees
@ryanml
Labels
design A design change, especially one which needs input from the design team feature/widgets QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.8.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Asset address text is not legible

Actual result:

image

Expected result:

Should have more contrast so that its legible

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? Na
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Na
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett
@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes feature/widgets labels Apr 15, 2020
@jamesmudgett
Copy link

Use #7d7d7d

@ryanml ryanml self-assigned this Apr 15, 2020
@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 15, 2020
ryanml added a commit to brave/brave-core that referenced this issue Apr 15, 2020
@ryanml
Fixes brave/brave-browser#9236 - Makes Deposit Address copy more visible
8f3897b
@ryanml ryanml mentioned this issue Apr 15, 2020
Merged
32 tasks
@srirambv srirambv mentioned this issue Apr 16, 2020
Closed
@ryanml ryanml mentioned this issue Apr 16, 2020
Merged
4 tasks
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified text is using #7D7D7D for text colour
    image

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified text is using #7D7D7D for text colour
    image

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified text is using #7D7D7D for text colour
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
design A design change, especially one which needs input from the design team feature/widgets QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Makes Deposit Address text on the Binance Widget more visible brave/brave-core
5 participants
@jamesmudgett @kjozwiak @ryanml @srirambv @LaurenWags