Binance version 2 trading widget (Uplift to 1.8.x) #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
force-pushed
the
binance-v2-1.8
branch
3 times, most recently
from
37ec485
to
97a63db
Compare
Binance version 2 trading widget
Fixes error/display issues before binance balances are fetched
Makes Deposit Address text on the Binance Widget more visible
Disconnects the Binance widget upon hiding
Brings unhidden crypto widget to the foreground
Binance widget no longer disconnects when offline.
Fixes crypto widgets titles, tab padding
Uses noopener for Binance URLs, client url validation
Persists selected view in the Binance Widget
Updates widget menu icons per theme
Makes convert text in the Binance widget summary more visible
Increases vertical height of Binance Widget, persists Nav menu
bsclifton
force-pushed
the
binance-v2-1.8
branch
from
97a63db
to
780e0bc
Compare
|
CI passed on all platforms except Android (timeout fetching source). Labelling as such and will restart |
bsclifton
added
CI/skip-ios
|
QA verified #5160 on Nightly as per #5160 (comment). |
kjozwiak
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of:
#5160
#5250
#5263
#5265
#5264
#5275
#5289
#5286
#5285
#5284
#5276
#5278
Issues:
brave/brave-browser#9118
brave/brave-browser#9206
brave/brave-browser#9236
brave/brave-browser#9244
brave/brave-browser#9245
brave/brave-browser#9253
brave/brave-browser#9254
brave/brave-browser#9249
brave/brave-browser#9317
brave/brave-browser#9257
brave/brave-browser#9261
brave/brave-browser#9263
brave/brave-browser#9283
brave/brave-browser#9284
Approved, please ensure that before merging:
After you merge: