Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiat value text is not properly visible #9263

Closed
srirambv opened this issue Apr 16, 2020 · 2 comments · Fixed by brave/brave-core#5276
Closed

Fiat value text is not properly visible #9263

srirambv opened this issue Apr 16, 2020 · 2 comments · Fixed by brave/brave-core#5276
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

Description

Fiat value text is not properly visible

Steps to Reproduce

  1. Connect Binance widget
  2. Switch to balance view to show
  3. Fiat value is not properly visible

Actual result:

image

Expected result:

Clearly visible text colour

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.9.24 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

should use the same colour text as used to fix #9236

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support feature/widgets labels Apr 16, 2020
@ryanml ryanml self-assigned this Apr 16, 2020
@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 16, 2020
ryanml added a commit to brave/brave-core that referenced this issue Apr 16, 2020
@srirambv
Copy link
Contributor Author

@ryanml this doesn't seem to be fixed on 1.9.37.
image
image

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified the new value for the text should be #5F5F5F as per confirmation from @jamesmudgett

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants