Make shortcut work on MacOS (uplift to 0.67.x) #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
|
I don't think this is in Nightly yet... I tried to make a shortcut to mobile.twitter.com and it didn't work |
|
@bsclifton Yup, It was merged after bumping to |
kjozwiak
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Uplift into 0.67.x approved. I basically went through the same plan outlined under #2553 (review) using 0.68.9 Chromium: 75.0.3770.38 and the crash has been resolved and the feature is generally working. @simonhong there's a few bugs with macOS which we can address in another PR. Lets get this merged as it fixes the crash.
Please make sure that all the correct labels are being used and the appropriate issue(s) is moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #2558
Approved, please ensure that before merging:
After you merge: