Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: 100% nightly for Android #336

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m self-assigned this Aug 24, 2022
@atuchin-m atuchin-m requested a review from a team as a code owner August 24, 2022 19:15
@atuchin-m atuchin-m merged commit 4e5293e into main Aug 24, 2022
@atuchin-m atuchin-m deleted the issues/24957/enable-translate-android-nightly branch August 24, 2022 19:23
@kjozwiak
Copy link
Member

For the above, I'm just going to check/ensure that Brave Translate gets enabled via Girffin rather than QAing the general functionality like I usually do as @stephendonner already went through it via brave/brave-browser#23770 (comment) & brave/brave-browser#23768 (comment) and confirmed that things are working as expected via 1.43.x. We're just enabling it by default via Griffin.

Used instructions via brave/brave-core#10408 (comment) as per the following:

linuxSeedStaging

Nightly channel

Verification PASSED on Pixel 6 running Android 13 via the following PR(s):

Brave | 1.45.2 Chromium: 105.0.5195.37 (Official Build) canary (32-bit)
--- | ---
Revision | 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS | Android 13; Build/TP1A.220624.021
  • installed 1.45.2 Chromium: 105.0.5195.37 and ensured that BraveTranslateAndroidStudy wasn't under brave://version
  • visited https://speigel.de and ensured that the translation UI wasn't visible as the Griffin study hasn't loaded/come into affect
Example Example
Screenshot_20220824-235813 Screenshot_20220824-235846
  • restarted the browser and ensured BraveTranslateAndroidStudy:Enabled via brave://version
  • visited https://speigel.de and ensured that the Brave Translate UI appeared
  • clicked on English and ensured that the page was being translated
Example Example Example
Screenshot_20220824-235914 Screenshot_20220824-235924 Screenshot_20220824-235931

BETA channel

Verification PASSED on Pixel 6 running Android 13 via the following PR(s):

Brave | 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (32-bit)
--- | ---
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Android 13; Build/TP1A.220624.021
  • ensured that BraveTranslateAndroidStudy doesn't appear under brave://version after restarting the browser
  • ensured that visiting https://speigel.de doesn't trigger the Brave Translate UI at the bottom of the page
Example Example
Screenshot_20220825-001217 Screenshot_20220825-001238

Release channel

Verification PASSED on Pixel 6 running Android 13 via the following PR(s):

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (32-bit)
--- | ---
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Android 13; Build/TP1A.220624.021
  • ensured that BraveTranslateAndroidStudy doesn't appear under brave://version after restarting the browser
  • ensured that visiting https://speigel.de doesn't trigger the Brave Translate UI at the bottom of the page
Example Example
Screenshot_20220825-001630 Screenshot_20220825-001700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants