Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Front end work for Brave Translate on Android #23770

Closed
timchilds opened this issue Jun 29, 2022 · 6 comments · Fixed by brave/brave-core#14283
Closed

[Android] Front end work for Brave Translate on Android #23770

timchilds opened this issue Jun 29, 2022 · 6 comments · Fixed by brave/brave-core#14283
Assignees

Comments

@timchilds
Copy link

Spec
https://docs.google.com/document/d/1LBmoyUveZaMcnycpRqg91lhzZFjDx_19zM3x6ulNpHg/edit?usp=sharing

@timchilds timchilds added OS/Android Fixes related to Android browser functionality brave-translate labels Jun 29, 2022
@timchilds timchilds changed the title [Android] Front-end work for Brave Translate on Android [Android] Front end work for Brave Translate on Android Jun 29, 2022
@Sam-Sibley
Copy link

@deeppandya @timchilds Attached are the translate icons, both dark and light, let me know if you need anything elsetranslate_light@2x
translate_light
translate_dark@2x
translate_dark

@deeppandya
Copy link

@Sam-Sibley can you provide .svg file ? using vector drawables are preferable over pngs

@timchilds
Copy link
Author

@deeppandya the SVGs are the second icons in @Sam-Sibley comment.

@Sam-Sibley
Copy link

@deeppandya These are the png icons for various Android sizes as discussed
translate icons.zip
:

@deeppandya
Copy link

@timchilds i am not if we should include this issue for release note. can you check and update the issue ?

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 18, 2022
@stephendonner
Copy link

stephendonner commented Aug 18, 2022

Verification PASSED using

Brave 1.43.74, Chromium 104.0.5112.102 on a Google Pixel XL running Android 9.

NOTE: Over in #23768, I covered enabling the feature, the top-level UI, and core Translate features, but left the remainder of the UI items for this issue.

Shared Steps:

  1. install 1.43.74
  2. launch Brave
  3. set both Enable internal translate engine (brave-translate-go) and Enable Chromium Translate feature to Enabled and tapped on Relaunch, to restart Brave

Correct icons (Light and Dark)

Light Dark
Screenshot_20220818-153534 Screenshot_20220818-153612

More languages

  1. loaded aol.com/de
  2. on the Brave translate toolbar, I clicked on the ellipsis
  3. confirmed the full list of translatable languages is present, and matches those in brave://translate-internals/
  4. selected Spanish
  5. confirmed the page was translated to Spanish, which is selected in the Brave translate toolbar
example example example
Screenshot_20220818-155355 Screenshot_20220818-160110 Screenshot_20220818-155913

Always translate pages in "(supported language)"

  1. loaded bbc.com/mundo
  2. tapped on the Brave translate ellipsis
  3. tapped on Always translate pages in Spanish
  4. confirmed the page auto-translated to Spanish
  5. loaded elpais.com/america
  6. confirmed it loaded in Spanish then re-rendered in English
  7. tapped on the ellipsis
  8. confirmed Always translate pages in Spanish was checked
example example example example
Screenshot_20220818-161511 Screenshot_20220818-161752 Screenshot_20220818-161812 Screenshot_20220818-161833

Never translate pages in "(supported language)"

  1. loaded mk.ru
  2. tapped on the Brave translate ellipsis
  3. tapped on Never translate pages in Russian
  4. confirmed the page remained in Russian
  5. loaded mail.ru
  6. confirmed it loaded in Russian
  7. confirmed there was no Brave translate toolbar at the bottom
example example example example example
Screenshot_20220818-163733 Screenshot_20220818-164303 Screenshot_20220818-163741 Screenshot_20220818-163849 Screenshot_20220818-163801

Never translate this site

  1. loaded jagran.com
  2. tapped on the Brave translate ellipsis
  3. tapped on Never translate this site
  4. confirmed the page remained in Hindi, and the translation toolbar went away
  5. loaded bbc.com/hindi
  6. confirmed it loaded in Hindi with the Brave translate toolbar visible
example example example example example example
Screenshot_20220818-165703 Screenshot_20220818-165718 Screenshot_20220818-165729 Screenshot_20220818-165903 Screenshot_20220818-165937 Screenshot_20220818-165954

Page is not in "(supported language)" ?

  1. loaded leggo.it
  2. tapped on the Brave translate toolbar's ellipsis
  3. tapped on the Page is not in Italian? menu item
  4. chose Polish
  5. confirmed the source language in the Brave translate toolbar changed to Polish
  6. confirmed a page translation from Polish to English was attempted (but didn't succeed, as the page isn't in Polish)
example example example example example
Screenshot_20220818-171443 Screenshot_20220818-171604 Screenshot_20220818-171706 Screenshot_20220818-172036 Screenshot_20220818-172049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants