Android translate to BETA 100% #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
approved these changes
Aug 25, 2022
kjozwiak
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Uplift into production approved 👍 QA has verified the PR on Nightly as per #339 (comment).
kjozwiak
deleted the
issues/338/enable-translate-android-beta-production
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #338
The PR enables translate in Android beta and merge desktop and Android studies into the one.
The following things have done to support merging:
Min version was bumped to "104.1.43.54" (we need [Android] Front end work for Brave Translate on Android brave-browser#23770) It covers beta/nightly builds not older than 3 weeks ago. IMHO it's okay: we shouldn't about older non-stable installations.
The proof that 1.43.54 has the commit
Group "Disabled" was removed (because "probability_weight": 0 and we can't explicitly disable
Translatefeature for desktops);Explicitly enabling
Translatefeature is added. It is enabled by default for Desktop(link), but not for Android (link).The next step is enable both desktop/android in release: #335