Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android translate to BETA 100% #339

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

atuchin-m
Copy link
Collaborator

Related #338

@atuchin-m atuchin-m self-assigned this Aug 25, 2022
@atuchin-m atuchin-m requested a review from a team as a code owner August 25, 2022 10:27
@atuchin-m atuchin-m merged commit 6abdf42 into main Aug 25, 2022
@kjozwiak kjozwiak deleted the issues/338/enable-translate-android-beta branch August 30, 2022 03:46
@kjozwiak
Copy link
Member

For the above, I'm just going to check/ensure that Brave Translate gets enabled via Girffin rather than QAing the general functionality like I usually do as @stephendonner already went through it via brave/brave-browser#23770 (comment) & brave/brave-browser#23768 (comment) and confirmed that things are working as expected via 1.43.x. We're just enabling it by default via Griffin on BETA.

Used instructions via brave/brave-core#10408 (comment) as per the following:

image

BETA channel

Verification PASSED on Samsung S10+ running Android 12 via the following PR(s):

Brave | 1.44.68 Chromium: 105.0.5195.68 (Official Build) beta (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016
  • installed 1.44.68 Chromium: 105.0.5195.68 and ensured that BraveTranslateAndroidStudy wasn't under brave://version
  • visited https://speigel.de and ensured that the translation UI wasn't visible as the Griffin study hasn't loaded/come into affect
Example Example
Screenshot_20220829-235832_Brave - Beta Screenshot_20220830-000306_Brave - Beta
  • restarted the browser and ensured BraveTranslateAndroidStudy:Enabled via brave://version
  • visited https://speigel.de and ensured that the Brave Translate UI appeared
  • clicked on English and ensured that the page was being translated
Example Example Example
Screenshot_20220830-000336_Brave - Beta Screenshot_20220830-000352_Brave - Beta Screenshot_20220830-000416_Brave - Beta

Release channel

Verification PASSED on Samsung S10+ running Android 12 via the following PR(s):

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (32-bit)
--- | ---
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Android 12; Build/SP1A.210812.016
  • ensured that BraveTranslateAndroidStudy doesn't appear under brave://version after restarting the browser
  • ensured that visiting https://speigel.de doesn't trigger the Brave Translate UI at the bottom of the page
Example Example
Screenshot_20220830-001152_Brave Screenshot_20220830-001234_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants