Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translate] Get Brave Translate functioning on Android #23768

Closed
timchilds opened this issue Jun 29, 2022 · 4 comments · Fixed by brave/brave-core#14047
Closed

[Translate] Get Brave Translate functioning on Android #23768

timchilds opened this issue Jun 29, 2022 · 4 comments · Fixed by brave/brave-core#14047
Assignees
@atuchin-m
Labels
brave-translate OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.43.x - Release

Comments

@timchilds
Copy link

timchilds commented Jun 29, 2022 •
edited
Loading

Per meeting with @rebron @moritzhaller @atuchin-m, there is some Chromium work required to get brave translate functioning on Android.

Find why the translation fails without loading the main script.
@timchilds timchilds added OS/Android Fixes related to Android browser functionality brave-translate labels Jun 29, 2022
@anthonypkeane
Copy link

Slack Link: https://bravesoftware.slack.com/archives/C02G7LEELQK/p1634748449086800

@atuchin-m atuchin-m mentioned this issue Jul 5, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 8, 2022
@atuchin-m
Copy link
Contributor

For QA:

  1. (Important) Check that there is no any translation attempt or UI by default (when the new feature is disabled).
  2. Enable the new flag Enable internal translate engine (brave-translate-go) and check that pages can be translated. Note the UI fixes (removing the google icon, menu and settings items) is still in progress.

@brave-builds brave-builds mentioned this issue Jul 12, 2022
Closed
7 tasks
@atuchin-m atuchin-m mentioned this issue Jul 15, 2022
Closed
@atuchin-m
Copy link
Contributor

atuchin-m commented Aug 2, 2022 •
edited
Loading

The uplift PR wasn't merged in 1.42.x, so I've removed 1.42.x milestone.
https://github.com/brave/brave-core/blob/1.42.x/browser/about_flags.cc#L425

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 18, 2022
@stephendonner
Copy link

stephendonner commented Aug 18, 2022 •
edited
Loading

Verification PASSED using

Brave 1.43.74, Chromium 104.0.5112.102 on a Google Pixel XL running Android 9.

Followed the steps to reproduce/testcase in #23768 (comment)

Case One Case Two
Screenshot_20220818-115654 Screenshot_20220818-115627

Case One: default - no translate UI, no offer to translate

Steps:

  1. installed 1.43.74
  2. skipped onboarding
  3. opened brave://flags
  4. confirmed both Enable internal translate engine (brave-translate-go) and Enable Chromium Translate feature were set to Default (disabled)
  5. loaded speigel.de, bbc.com/mundo, www.jagran.com, www.wp.pl, and mail.ru

Confirmed:

  • no UI offering to translate, near the bottom toolbar
  • no Translate menu item
speigel.de bbc.com/mundo www.jagran.com www.wp.pl mail.ru
Screenshot_20220818-110644 Screenshot_20220818-110510 Screenshot_20220818-110730 Screenshot_20220818-110544 Screenshot_20220818-112115

Case Two: enabled Brave translate

Steps:

  1. installed 1.43.74
  2. skipped onboarding
  3. opened brave://flags
  4. set both Enable internal translate engine (brave-translate-go) and Enable Chromium Translate feature to Enabled and tapped on Relaunch, to restart Brave
  5. loaded speigel.de, bbc.com/mundo, www.jagran.com, www.wp.pl, and mail.ru

Confirmed:

  • correct language was auto-detected and selected, in the Brave translate toolbar
  • Translate... menu item auto-translated to my detected, preferred language, English

UI

speigel.de bbc.com/mundo www.jagran.com www.wp.pl mail.ru
Screenshot_20220818-113231 Screenshot_20220818-112935 Screenshot_20220818-113615 Screenshot_20220818-113109 Screenshot_20220818-112622

Translation

speigel.de bbc.com/mundo www.jagran.com www.wp.pl mail.ru
Screenshot_20220818-113242 Screenshot_20220818-112944 Screenshot_20220818-113625 Screenshot_20220818-112824 Screenshot_20220818-112630

@stephendonner stephendonner added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 18, 2022
@stephendonner stephendonner mentioned this issue Aug 18, 2022
Closed
This was referenced Aug 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atuchin-m atuchin-m

Labels
brave-translate OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Android translate brave/brave-core
5 participants
@stephendonner @anthonypkeane @timchilds @brave-builds @atuchin-m