Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN-333] Prevent infinite DRS download retries #7679

Merged
merged 7 commits into from
Jan 23, 2025
Merged

[AN-333] Prevent infinite DRS download retries #7679

merged 7 commits into from
Jan 23, 2025

Conversation

lucymcnatt
Copy link
Contributor

@lucymcnatt lucymcnatt commented Jan 16, 2025 •
edited
Loading

Description

There was a bug in our retry logic that results in DRS downloads infinitely retrying in some cases. To fix this we moved the max retry check and added a test

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

LizBaldo
LizBaldo approved these changes Jan 17, 2025
View reviewed changes
Copy link

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the change makes sense. You mentioned that the tricky part was around testing. Did you meant manual testing, or adding a new unit test?

@lucymcnatt lucymcnatt marked this pull request as ready for review January 23, 2025 15:23
@lucymcnatt lucymcnatt requested a review from a team as a code owner January 23, 2025 15:23
@lucymcnatt lucymcnatt enabled auto-merge (squash) January 23, 2025 20:00
@lucymcnatt lucymcnatt disabled auto-merge January 23, 2025 20:43
@lucymcnatt lucymcnatt enabled auto-merge (squash) January 23, 2025 20:44
@lucymcnatt lucymcnatt merged commit 2c134ec into develop Jan 23, 2025
43 of 44 checks passed
@lucymcnatt lucymcnatt deleted the AN-333-drs-retry branch January 23, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizBaldo LizBaldo LizBaldo approved these changes

@jgainerdewar jgainerdewar jgainerdewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucymcnatt @jgainerdewar @LizBaldo