[AN-333] Prevent infinite DRS download retries

cromwell-drs-localizer/src/main/scala/drs/localizer/downloaders/GcsUriDownloader.scala

@@ -57,22 +57,25 @@
                           downloadAttempt: Int = 0
   ): IO[DownloadResult] = {
 
-    def maybeRetryForDownloadFailure(t: Throwable): IO[DownloadResult] =
-      if (downloadAttempt < downloadRetries) {
-        backoff foreach { b => Thread.sleep(b.backoffMillis) }
-        logger.warn(s"Attempting download retry $downloadAttempt of $downloadRetries for a GCS url", t)
-        downloadWithRetries(downloadRetries,
-                            backoff map {
-                              _.next
-                            },
-                            downloadAttempt + 1
-        )
-      } else {
-        IO.raiseError(new RuntimeException(s"Exhausted $downloadRetries resolution retries to download GCS file", t))
-      }
+    if (downloadAttempt < downloadRetries) {
+      backoff foreach { b => Thread.sleep(b.backoffMillis) }
+      logger.warn(s"Attempting download retry $downloadAttempt of $downloadRetries for a GCS url")
+      downloadWithRetries(downloadRetries,
+                          backoff map {
+                            _.next
+                          },
+                          downloadAttempt + 1
+      )
+    } else {
+      IO.raiseError(new RuntimeException(s"Exhausted $downloadRetries resolution retries to download GCS file"))
+    }
+
+    // Necessary function to handle the throwable when trying to recover a failed download
+    def handleDownloadFailure(t: Throwable): IO[DownloadResult] =
+      downloadWithRetries(downloadRetries, backoff, downloadAttempt + 1)
 
     runDownloadCommand.redeemWith(
-      recover = maybeRetryForDownloadFailure,
+      recover = handleDownloadFailure,
       bind = {
         case s: DownloadSuccess.type =>
           IO.pure(s)