Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error informative for non-diploid family likelihoods #3329

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Make error informative for non-diploid family likelihoods #3329

merged 1 commit into from
Sep 11, 2017

Conversation

ronlevine
Copy link
Contributor

Implements #3320.
Was throwing a ArrayIndexOutOfBoundsException because the number of PLs is set to 3. This is only true for diploid biallelics.

@ronlevine ronlevine self-assigned this Jul 21, 2017
@ronlevine ronlevine requested a review from vdauwera July 21, 2017 20:42
@ronlevine
Copy link
Contributor Author

@vdauwera Please review.

@codecov-io
Copy link

codecov-io commented Jul 21, 2017 •
edited
Loading

Codecov Report

Merging #3329 into master will decrease coverage by 0.004%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##              master     #3329       +/-   ##
===============================================
- Coverage     80.443%   80.439%   -0.004%     
  Complexity     17395     17395               
===============================================
  Files           1168      1168               
  Lines          62907     62910        +3     
  Branches        9800      9802        +2     
===============================================
  Hits           50604     50604               
- Misses          8376      8378        +2     
- Partials        3927      3928        +1
Impacted Files Coverage Δ Complexity Δ
...kers/variantutils/CalculateGenotypePosteriors.java 85.915% <ø> (ø) 13 <0> (ø) ⬇️
.../tools/walkers/variantutils/FamilyLikelihoods.java 80.349% <0%> (-1.067%) 57 <0> (ø)

@ronlevine
Copy link
Contributor Author

Ping @vdauwera

lbergelson
lbergelson approved these changes Sep 11, 2017
View reviewed changes
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good 👍

@lbergelson lbergelson merged commit d411da1 into master Sep 11, 2017
@lbergelson lbergelson deleted the rhl_calc_post_gl_err_3320 branch September 11, 2017 19:59
vruano pushed a commit that referenced this pull request Oct 5, 2017
@ronlevine @vruano
Make error informative for non-diploid family likelihoods #3320 (#3329)
0015969 
throw a UserException instead of ArrayIndexOutOfBounds
fixes #3320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbergelson lbergelson lbergelson approved these changes

@vdauwera vdauwera Awaiting requested review from vdauwera

Assignees

@ronlevine ronlevine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronlevine @codecov-io @lbergelson