Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a .dockerignore file to the gatk #3418

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Conversation

jamesemery
Copy link
Collaborator

This reduces the size of the docker image from ~9GB when LFS tests were being run to 2.74GB

fixes #3414

…from being loaded into the docker image in order to reduce the side of the docker image.

fixes #3414
@codecov-io
Copy link

Codecov Report

Merging #3418 into master will increase coverage by 0.003%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #3418       +/-   ##
===============================================
+ Coverage     80.506%   80.509%   +0.003%     
  Complexity     17555     17555               
===============================================
  Files           1175      1175               
  Lines          63500     63500               
  Branches        9896      9896               
===============================================
+ Hits           51121     51123        +2     
+ Misses          8428      8426        -2     
  Partials        3951      3951
Impacted Files Coverage Δ Complexity Δ
...e/hellbender/engine/spark/SparkContextFactory.java 73.973% <0%> (+2.74%) 11% <0%> (ø) ⬇️

@droazen
Copy link
Contributor

droazen commented Aug 9, 2017

@LeeTL1220 Can you review?

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@jamesemery jamesemery merged commit c655fef into master Aug 10, 2017
@jamesemery jamesemery deleted the je_dockerIgnore_3414 branch August 10, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove test resources from the docker image
4 participants