prevent accidental toString call during validation #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* profiling of GenotypeGVCFs showed a lot of wasted time in VariantContext.toString() which can be tracked to computing an error message we never display in AFCalculator.getLog10PNonRef() * fixing it so we only compute the message when we the error occurs
Codecov Report
@@ Coverage Diff @@
## master #3478 +/- ##
==============================================
+ Coverage 80.32% 80.326% +0.006%
Complexity 17704 17704
==============================================
Files 1181 1181
Lines 64013 64013
Branches 9943 9942 -1
==============================================
+ Hits 51415 51419 +4
+ Misses 8642 8639 -3
+ Partials 3956 3955 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
profiling of GenotypeGVCFs showed a lot of wasted time in VariantContext.toString() which can be tracked to computing an error message we never display in
AFCalculator.getLog10PNonReffixing it so we only compute the message when we the error occurs