Use a handmade TestReferenceMultiSource in tests instead of a mock. #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
reviewed
Sep 18, 2017
| // since in some cases they're used as a Spark broadcast variable. Mocks are mutated when they're | ||
| // accessed, which can result in ConcurrentModificationExceptions during serialization/broadcast. | ||
| // So we need to allow test code to create a subclass that provides a "fake" implementation of this | ||
| // class without actually being a mock. |
There was a problem hiding this comment.
This comment might be more appropriate in a test class -- here you should just document concisely why the default constructor is protected.
droazen
reviewed
Sep 18, 2017
| return true; | ||
| } | ||
|
|
||
| public SerializableFunction<GATKRead, SimpleInterval> getReferenceWindowFunction() { |
droazen
approved these changes
Sep 18, 2017
Codecov Report
@@ Coverage Diff @@
## master #3586 +/- ##
===============================================
- Coverage 79.736% 79.733% -0.003%
- Complexity 18147 18149 +2
===============================================
Files 1217 1217
Lines 66601 66602 +1
Branches 10429 10429
===============================================
- Hits 53105 53104 -1
- Misses 9289 9292 +3
+ Partials 4207 4206 -1
|
cmnbroad
force-pushed
the
cn_remove_referencesource_mock
branch
from
8823dde
to
7548ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had ConcurrentModificationExceptions several times when mocked ReferenceMultiSource objects are both mocked and broadcast (for example). Mocks appear to be mutated, even when the mocked object is immutable, so serialization can fail. This replaces the mock object with a faked one.