Fix bad version check in manage_sv_pipeline.sh #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manage_sv_pipeline checks version from gatk-spark.jar and compares it to the current git hash (to ensure the correct version is run). Newer gatk versions had a slightly different file name format and caused errors parsing the hash. This updates the hash check and produces more comprehensible error messages when it fails. Resolves: #3593
vruano
approved these changes
Sep 20, 2017
Codecov Report
@@ Coverage Diff @@
## master #3595 +/- ##
===============================================
+ Coverage 79.736% 79.738% +0.002%
- Complexity 18148 18149 +1
===============================================
Files 1217 1217
Lines 66602 66602
Branches 10429 10429
===============================================
+ Hits 53106 53107 +1
Misses 9289 9289
+ Partials 4207 4206 -1
|
tedsharpe
pushed a commit
that referenced
this pull request
Sep 22, 2017
manage_sv_pipeline checks version from gatk-spark.jar and compares it to the current git hash (to ensure the correct version is run). Newer gatk versions had a slightly different file name format and caused errors parsing the hash. This updates the hash check and produces more comprehensible error messages when it fails. Resolves: #3593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manage_sv_pipeline checks version from gatk-spark.jar and compares it
to the current git hash (to ensure the correct version is run). Newer
gatk versions had a slightly different file name format and caused
errors parsing the hash. This updates the hash check and produces
more comprehensible error messages when it fails.
Resolves: #3593