Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made min-base-quality-score argument actually do something. Closes #4126. #4128

Merged
merged 1 commit into from
Jan 11, 2018
Merged

made min-base-quality-score argument actually do something. Closes #4126. #4128

merged 1 commit into from
Jan 11, 2018

Conversation

davidbenjamin
Copy link
Contributor

@lbergelson Does this look reasonable to you?

lbergelson
lbergelson approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@davidbenjamin davidbenjamin merged commit cce80b0 into master Jan 11, 2018
@davidbenjamin davidbenjamin deleted the db_issue_4126 branch January 11, 2018 20:01
@droazen
Copy link
Contributor

droazen commented Jan 11, 2018

@davidbenjamin Can you implement a simple integration test for this arg, to ensure it doesn't break again?

@davidbenjamin davidbenjamin mentioned this pull request Jan 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbergelson lbergelson lbergelson approved these changes

Assignees

@davidbenjamin davidbenjamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidbenjamin @droazen @lbergelson