Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed more mem_gb parameters and fixed mem_gb_for_model_segments. #4364

Merged
merged 2 commits into from
Feb 7, 2018

Conversation

samuelklee
Copy link
Contributor

@samuelklee samuelklee commented Feb 7, 2018

Closes #4353.
Closes #4362.

@samuelklee
Copy link
Contributor Author

@LeeTL1220 I went ahead and exposed more mem_gb parameters, which is convenient when we want to go below 250bp and the pair WDL is used as a subworkflow. Please review carefully!

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelklee Looks good.... workflow inputs exist. Each are wired into the correct tasks.

@samuelklee
Copy link
Contributor Author

Thanks @LeeTL1220, I also added another commit to make some minor comment tweaks. Will merge after tests pass!

@LeeTL1220
Copy link
Contributor

@samuelklee Still looks good.

@codecov-io
Copy link

codecov-io commented Feb 7, 2018

Codecov Report

Merging #4364 into master will increase coverage by 0.003%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #4364       +/-   ##
===============================================
+ Coverage     79.099%   79.102%   +0.003%     
+ Complexity     16659     16658        -1     
===============================================
  Files           1050      1050               
  Lines          59681     59681               
  Branches        9754      9754               
===============================================
+ Hits           47207     47209        +2     
+ Misses          8688      8685        -3     
- Partials        3786      3787        +1
Impacted Files Coverage Δ Complexity Δ
...park/sv/discovery/alignment/AlignmentInterval.java 89.272% <0%> (-0.383%) 73% <0%> (-1%)
...e/hellbender/engine/spark/SparkContextFactory.java 73.973% <0%> (+2.74%) 11% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+10%) 3% <0%> (ø) ⬇️

@samuelklee samuelklee merged commit 8ac4668 into master Feb 7, 2018
@samuelklee samuelklee deleted the sl_wdl_fix_another_one branch February 7, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants