-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV Tumor only WDL #4414
CNV Tumor only WDL #4414
Conversation
… automated tests. Adding first automated test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of very minor comments. Thanks @LeeTL1220!
# Tumor only WGS w/ explicit GC correction | ||
java -jar ~/${CROMWELL_JAR} run /home/travis/build/broadinstitute/gatk/scripts/cnv_wdl/somatic/cnv_somatic_pair_workflow.wdl -i cnv_somatic_pair_wgs_do-gc_tumor_only_workflow_mod.json | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove white space to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
mem_gb = mem_gb_for_collect_counts, | ||
disk_space_gb = collect_counts_normal_disk, | ||
preemptible_attempts = preemptible_attempts | ||
if (defined(normal_bam)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything stopping you from putting all of the tasks for the normal in a single if
block? (If so, no biggie.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelklee I just wanted to preserve the order. My logic was simply so that we keep the like tasks together. If you would like me to change it, no problem. Just tell me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to put them all in the same block.
At some point, we can extract a single-sample subworkflow that takes allelic counts from a matched normal as an optional input to the ModelSegments task (since that is the only difference between running the normal and the tumor). This pair workflow will just be two calls to that single-sample workflow. However, this can definitely wait until Cromwell handles subworkflows more elegantly.
@samuelklee Put the normal sample processing into one |
Codecov Report
@@ Coverage Diff @@
## master #4414 +/- ##
===============================================
+ Coverage 79.024% 79.025% +0.002%
+ Complexity 16447 16446 -1
===============================================
Files 1047 1047
Lines 59186 59186
Branches 9672 9672
===============================================
+ Hits 46771 46772 +1
- Misses 8659 8660 +1
+ Partials 3756 3754 -2
|
Fixes #3983