Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose GenomicsDBArgumentCollection with CreateSomaticPanelOfNormals #6746

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Expose GenomicsDBArgumentCollection with CreateSomaticPanelOfNormals #6746

merged 1 commit into from
Dec 23, 2022

Conversation

nalinigans
Copy link
Collaborator

Since GenomicsDB can be used with CreateSomaticPanelOfNormals, allow for the GenomicsDBArgumentCollection to be exposed with this tool.

@droazen droazen self-requested a review September 1, 2020 16:08
@droazen droazen self-assigned this Sep 1, 2020
@droazen
Copy link
Contributor

droazen commented Oct 8, 2020

@davidbenjamin Since this changes the CreateSomaticPanelOfNormals test code, would you mind having a look when you get a chance?

davidbenjamin
davidbenjamin approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@davidbenjamin davidbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@lbergelson lbergelson merged commit 9ffd649 into master Dec 23, 2022
@lbergelson lbergelson deleted the genomicsdb_6744 branch December 23, 2022 21:24
@lbergelson
Copy link
Member

This was approved but never merged so I put it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbenjamin davidbenjamin davidbenjamin approved these changes

@droazen droazen Awaiting requested review from droazen

Assignees

@droazen droazen

@davidbenjamin davidbenjamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nalinigans @droazen @lbergelson @davidbenjamin