Upgrade to Gradle 7 #7609
Merged
Upgrade to Gradle 7 #7609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergelson
reviewed
Dec 17, 2021
| @@ -411,8 +409,8 @@ def createSymlinks(archivePath, symlinkLocation) { | |||
| def createGatkSymlinks(destinationDir, archivePath, suffix, baseJarName, secondaryBaseJarName) { | |||
| def finalSuffix = (suffix == "") ? "" : ("-" + suffix) | |||
|
|
|||
| def symlinkLocation = destinationDir.toString() + "/" + baseJarName + finalSuffix + ".jar" | |||
| def symlinkLocation2 = destinationDir.toString() + "/" + secondaryBaseJarName + finalSuffix + ".jar" | |||
| def symlinkLocation = destinationDir.getAsFile().get().toString() + "/" + baseJarName + finalSuffix + ".jar" | |||
There was a problem hiding this comment.
this one is strange but I don't know the intended magic way to do it
There was a problem hiding this comment.
Yeah -- the destinationDir is a DirectoryProperty which you can turn into a Provider with getAsFile() but to resolve that Provider -> File you call .get()
lbergelson
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
@kcibul 👍
We need to update the readme and wiki with. the new commands but lets do that separately.
gbggrant
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Initial upgrade to gradle 6.9.1 * update shadow plugin * change jacoco syntax * remove most deprecation warnings * changed compile -> implementation * more warnings * fixed shadow jar deps * removed jCenter * publishing * attempt to upgrade to gradle7 * Remove local shadow jar from published components * updated readme, select correct repo for publish * add names back to pom Co-authored-by: Louis Bergelson <louisb@broadinstitute.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Gradle 7
Caveats