Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom VariantClassification severity ordering. #7673

Merged
merged 9 commits into from
Mar 8, 2022

Conversation

jonn-smith
Copy link
Collaborator

  • Added custom VariantClassification severity ordering. This enables users to have variants annotated consistently in an alternate order by the results of their variant classification. (user requested)

@jonn-smith
Copy link
Collaborator Author

@xaviloinaz here's that feature you requested for configurable ordering of funotations via VariantClassifications. It's basically what we talked about - you supply a TSV file with VARIANT_CLASSIFICATION SEVERITY, and Funcotator will respect that new order.

Let me know if this won't work for what you wanted to do.

@jonn-smith jonn-smith force-pushed the jts_funcotator_variant_class_custom_order branch from 4a10f74 to c44e964 Compare February 17, 2022 03:39
@jonn-smith jonn-smith force-pushed the jts_funcotator_variant_class_custom_order branch from c44e964 to b9df7c8 Compare February 17, 2022 16:01
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonn-smith Back to you with my comments

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 merge when tests pass @jonn-smith

@jonn-smith jonn-smith merged commit 2c63e72 into master Mar 8, 2022
@jonn-smith jonn-smith deleted the jts_funcotator_variant_class_custom_order branch March 8, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants