Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some generic read tag/expression fliters for use on numeric tags #7746

Merged
merged 3 commits into from
May 10, 2022

Conversation

jamesemery
Copy link
Collaborator

No description provided.

@jamesemery jamesemery requested a review from droazen March 30, 2022 19:38
@gatk-bot
Copy link

Travis reported job failures from build 38347
Failures in the following jobs:

Test Type JDK Job ID Logs
integration openjdk11 38347.12 logs

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesemery One small typo in one comment, otherwise looks good 👍

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #7746 (b94782d) into master (c6eb337) will increase coverage by 68.309%.
The diff coverage is 82.789%.

@@               Coverage Diff                @@
##              master     #7746        +/-   ##
================================================
+ Coverage     18.644%   86.953%   +68.309%     
- Complexity      4635     36924     +32289     
================================================
  Files           1261      2218       +957     
  Lines          73745    173663     +99918     
  Branches       11768     18750      +6982     
================================================
+ Hits           13749    151006    +137257     
+ Misses         57944     16050     -41894     
- Partials        2052      6607      +4555     
Impacted Files Coverage Δ
...ine/GATKPlugin/GATKAnnotationPluginDescriptor.java 83.851% <ø> (+46.584%) ⬆️
...ine/GATKPlugin/GATKReadFilterPluginDescriptor.java 84.615% <ø> (+32.308%) ⬆️
...nder/cmdline/PicardCommandLineProgramExecutor.java 63.636% <0.000%> (+63.636%) ⬆️
...e/argumentcollections/DbsnpArgumentCollection.java 100.000% <ø> (ø)
...llections/MultiVariantInputArgumentCollection.java 100.000% <ø> (+100.000%) ⬆️
...broadinstitute/hellbender/engine/FeatureCache.java 92.157% <ø> (+19.608%) ⬆️
...oadinstitute/hellbender/engine/FeatureContext.java 81.818% <ø> (+72.727%) ⬆️
...roadinstitute/hellbender/engine/ProgressMeter.java 93.814% <ø> (+7.899%) ⬆️
...g/broadinstitute/hellbender/engine/ReadWalker.java 100.000% <ø> (+7.407%) ⬆️
...tute/hellbender/engine/ReadlessAssemblyRegion.java 46.667% <ø> (+46.667%) ⬆️
... and 2327 more

@jamesemery jamesemery merged commit a3141f7 into master May 10, 2022
@jamesemery jamesemery deleted the je_newGenericReadTagFiltering branch May 10, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants