Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over to github actions for building our nightly docker image #7775

Merged
merged 8 commits into from
Apr 13, 2022

Conversation

jamesemery
Copy link
Collaborator

No description provided.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesemery Looks google to me. Have you run the generated docker and made sure it doesn't explode?

schedule:
# trigger the job the image at 1am est every night (UTC 20:00)
# NOTE: by default schedule:cron jobs pull from the repo default branch which makes this the master branch of gatk
- cron: '0 20 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cron has such a weird notation for timing.

images: broadinstitute/gatk-nightly
tags: |
type=raw,value=${{env.DOCKER_NIGHTLY_TAG}}
type=raw,value=${{env.DOCKER_NIGHTLY_TAG_LATEST}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like learning the docker tag domain specific language you can probably do this same thing with their magic built ins. I think it's reasonable to NOT do that though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent some time looking into that and it looked neat but i figure its probably better to keep the images using the same name scheme as before

jobs:
buildDocker:
name: build docker images
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't thought about this before, but we can probably save 20 seconds by using alpine linux instead of ubuntu. Kind of useless savings though.

@jamesemery jamesemery merged commit 318fa84 into master Apr 13, 2022
@jamesemery jamesemery deleted the je_gatkNightliesWithGithubActions branch April 13, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants