-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch over to github actions for building our nightly docker image #7775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesemery Looks google to me. Have you run the generated docker and made sure it doesn't explode?
schedule: | ||
# trigger the job the image at 1am est every night (UTC 20:00) | ||
# NOTE: by default schedule:cron jobs pull from the repo default branch which makes this the master branch of gatk | ||
- cron: '0 20 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cron has such a weird notation for timing.
images: broadinstitute/gatk-nightly | ||
tags: | | ||
type=raw,value=${{env.DOCKER_NIGHTLY_TAG}} | ||
type=raw,value=${{env.DOCKER_NIGHTLY_TAG_LATEST}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel like learning the docker tag domain specific language you can probably do this same thing with their magic built ins. I think it's reasonable to NOT do that though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent some time looking into that and it looked neat but i figure its probably better to keep the images using the same name scheme as before
jobs: | ||
buildDocker: | ||
name: build docker images | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't thought about this before, but we can probably save 20 seconds by using alpine linux instead of ubuntu. Kind of useless savings though.
No description provided.