Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code in solver package. #7922

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

cmnbroad
Copy link
Collaborator

This code appears to be unused, and causes (minor) problems on newer versions of Java, so I propose we remove it.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #7922 (f991a91) into master (8341ae5) will decrease coverage by 0.002%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #7922       +/-   ##
===============================================
- Coverage     87.072%   87.070%   -0.002%     
+ Complexity     37002     36941       -61     
===============================================
  Files           2221      2215        -6     
  Lines         173927    173691      -236     
  Branches       18793     18778       -15     
===============================================
- Hits          151441    151232      -209     
+ Misses         15850     15831       -19     
+ Partials        6636      6628        -8     
Impacted Files Coverage Δ
...nder/utils/runtime/StreamingProcessController.java 68.182% <0.000%> (+0.909%) ⬆️

@cmnbroad cmnbroad marked this pull request as ready for review June 28, 2022 21:32
@cmnbroad cmnbroad merged commit f6b1ef0 into master Jun 28, 2022
@cmnbroad cmnbroad deleted the cn_remove_solver_code branch June 28, 2022 22:07
@cmnbroad
Copy link
Collaborator Author

Thanks @samuelklee!

@samuelklee
Copy link
Contributor

Just for the record, as referenced in Slack, I managed to track down the previous PR in which this code was saved from the chopping block: #4181 But our current reasons are certainly compelling enough---we'll pour one out for Mehrtash's beloved solvers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants