Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud tests for CompareReferences and CheckReferenceCompatibility tools #7973

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

orlicohen
Copy link
Contributor

No description provided.

@droazen droazen self-assigned this Aug 3, 2022
@droazen droazen self-requested a review August 3, 2022 15:46
};
}

@Test(dataProvider = "cloudInputData"/*, groups = "bucket"*/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlicohen groups = "bucket" Needs to be uncommented here and in the other test before these will be able to pass on github

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #7973 (397f40b) into master (c22972a) will increase coverage by 34.421%.
The diff coverage is 0.000%.

@@               Coverage Diff                @@
##              master     #7973        +/-   ##
================================================
+ Coverage     52.260%   86.680%   +34.421%     
- Complexity     29146     38451      +9305     
================================================
  Files           2310      2310                
  Lines         180344    180387        +43     
  Branches       19840     19846         +6     
================================================
+ Hits           94247    156360     +62113     
+ Misses         80124     17084     -63040     
- Partials        5973      6943       +970     
Impacted Files Coverage Δ
.../hellbender/tools/reference/CompareReferences.java 66.667% <ø> (ø)
...ce/CheckReferenceCompatibilityIntegrationTest.java 74.359% <0.000%> (-19.189%) ⬇️
...ls/reference/CompareReferencesIntegrationTest.java 61.111% <0.000%> (-16.354%) ⬇️
...roadinstitute/hellbender/tools/LocalAssembler.java 67.425% <0.000%> (+0.073%) ⬆️
...roadinstitute/hellbender/utils/read/ReadUtils.java 82.278% <0.000%> (+0.316%) ⬆️
...stitute/hellbender/cmdline/CommandLineProgram.java 84.516% <0.000%> (+0.645%) ⬆️
...lyBasedSVDiscoveryTestDataProviderForSimpleSV.java 100.000% <0.000%> (+0.894%) ⬆️
.../main/java/org/broadinstitute/hellbender/Main.java 72.685% <0.000%> (+1.389%) ⬆️
...llbender/engine/filters/SoftClippedReadFilter.java 94.286% <0.000%> (+2.857%) ⬆️
.../hellbender/utils/python/PythonUnitTestRunner.java 78.689% <0.000%> (+3.279%) ⬆️
... and 588 more

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good @orlicohen -- merge once tests pass

@orlicohen orlicohen merged commit 8d81423 into master Aug 4, 2022
@orlicohen orlicohen deleted the oc_cloudtest branch August 4, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants