require reference as asserted in documentation #8067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
approved these changes
Oct 21, 2022
| @Test(expectedExceptions = CommandLineException.class) | ||
| public void requiresReferenceTest() throws IOException { | ||
| // This test is a bit more like the real world | ||
| final File outputFile = File.createTempFile("mergeannotatedregions", ".seg"); |
There was a problem hiding this comment.
This method doesn't clean up after itself -- use the createTempFile() method inherited from BaseTest instead, which sets the temp file to be deleted on JVM exit.
| arguments.add("--" + CopyNumberStandardArgument.SEGMENTS_FILE_LONG_NAME); | ||
| arguments.add(SIMPLE_TEST_FILE); | ||
| arguments.add("-" + StandardArgumentDefinitions.OUTPUT_SHORT_NAME); | ||
| arguments.add(outputFile.getAbsolutePath()); |
There was a problem hiding this comment.
In the future consider using ArgumentsBuilder to build up your integration test command lines (though the manual method here is fine too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation specifies that a reference is required; this PR enforces this requirement.