Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: Add version numbers to all WIT files and packages #7171

Closed
alexcrichton opened this issue Oct 6, 2023 · 1 comment · Fixed by #7272
Closed

wasi: Add version numbers to all WIT files and packages #7171

alexcrichton opened this issue Oct 6, 2023 · 1 comment · Fixed by #7272
Assignees
@alexcrichton

Comments

@alexcrichton
Copy link
Member

This should be done, or decided not to be done, before finalizing preview2.
@alexcrichton alexcrichton self-assigned this Oct 6, 2023
@pchickey
Copy link
Contributor

We plan to put a version tag on all wasi wits prior to the wasmtime 15 release cut.

alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Oct 17, 2023
@alexcrichton
Put versions in all WASI WIT files
874b0e8 
This commit starts exercising the versioning feature of WIT by ensuring
that all WASI descriptions have a version associated with them. The
version chosen is 0.2.0 which reflects the upcoming "preview 2" release
where in theory 0.1.0 was claimed by preview1. This is intended to stay
as 0.2.0 for now and we'll determine how best to update these numbers in
the future once preview2 is released.

Closes bytecodealliance#7171
@alexcrichton alexcrichton mentioned this issue Oct 17, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2023
@alexcrichton
Put versions in all WASI WIT files (#7272)
4258dd9 
* Put versions in all WASI WIT files

This commit starts exercising the versioning feature of WIT by ensuring
that all WASI descriptions have a version associated with them. The
version chosen is 0.2.0 which reflects the upcoming "preview 2" release
where in theory 0.1.0 was claimed by preview1. This is intended to stay
as 0.2.0 for now and we'll determine how best to update these numbers in
the future once preview2 is released.

Closes #7171

* Allow omitting versions in `with` keys

As a convenience for now this enables omitting the version of an
interface from a `with` key. This has a risk of not working well if two
packages are present and one has a version and one doesn't, but that's
left as a PR to fix in the future as the benefit of avoiding repetition
seems good for now.

* Allow omitting versions in trappable_error_types

* Use 0.2.0-rc-2023-10-18 as a version number

* More test fixes

* Fix another test
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Oct 19, 2023
@alexcrichton
Put versions in all WASI WIT files (bytecodealliance#7272)
312854e 
* Put versions in all WASI WIT files

This commit starts exercising the versioning feature of WIT by ensuring
that all WASI descriptions have a version associated with them. The
version chosen is 0.2.0 which reflects the upcoming "preview 2" release
where in theory 0.1.0 was claimed by preview1. This is intended to stay
as 0.2.0 for now and we'll determine how best to update these numbers in
the future once preview2 is released.

Closes bytecodealliance#7171

* Allow omitting versions in `with` keys

As a convenience for now this enables omitting the version of an
interface from a `with` key. This has a risk of not working well if two
packages are present and one has a version and one doesn't, but that's
left as a PR to fix in the future as the benefit of avoiding repetition
seems good for now.

* Allow omitting versions in trappable_error_types

* Use 0.2.0-rc-2023-10-18 as a version number

* More test fixes

* Fix another test
alexcrichton added a commit that referenced this issue Oct 19, 2023
@alexcrichton
Put versions in all WASI WIT files (#7272) (#7299)
b8286f9 
* Put versions in all WASI WIT files

This commit starts exercising the versioning feature of WIT by ensuring
that all WASI descriptions have a version associated with them. The
version chosen is 0.2.0 which reflects the upcoming "preview 2" release
where in theory 0.1.0 was claimed by preview1. This is intended to stay
as 0.2.0 for now and we'll determine how best to update these numbers in
the future once preview2 is released.

Closes #7171

* Allow omitting versions in `with` keys

As a convenience for now this enables omitting the version of an
interface from a `with` key. This has a risk of not working well if two
packages are present and one has a version and one doesn't, but that's
left as a PR to fix in the future as the benefit of avoiding repetition
seems good for now.

* Allow omitting versions in trappable_error_types

* Use 0.2.0-rc-2023-10-18 as a version number

* More test fixes

* Fix another test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
Ship WASI Preview 2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put versions in all WASI WIT files alexcrichton/wasmtime
2 participants
@alexcrichton @pchickey