[14.0.0] Put versions in all WASI WIT files #7299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Put versions in all WASI WIT files This commit starts exercising the versioning feature of WIT by ensuring that all WASI descriptions have a version associated with them. The version chosen is 0.2.0 which reflects the upcoming "preview 2" release where in theory 0.1.0 was claimed by preview1. This is intended to stay as 0.2.0 for now and we'll determine how best to update these numbers in the future once preview2 is released. Closes bytecodealliance#7171 * Allow omitting versions in `with` keys As a convenience for now this enables omitting the version of an interface from a `with` key. This has a risk of not working well if two packages are present and one has a version and one doesn't, but that's left as a PR to fix in the future as the benefit of avoiding repetition seems good for now. * Allow omitting versions in trappable_error_types * Use 0.2.0-rc-2023-10-18 as a version number * More test fixes * Fix another test
fitzgen
approved these changes
Oct 19, 2023
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 19, 2023
This commit updates the version numbers on `main` to no longer clash with the 14.0.0 release after bytecodealliance#7299. The version number is chosen as the branch point for the 15.0.0 release of Wasmtime, at which point we'll update the versions again.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
* Update WASI versions to `0.2.0-rc-2023-11-05` This commit updates the version numbers on `main` to no longer clash with the 14.0.0 release after #7299. The version number is chosen as the branch point for the 15.0.0 release of Wasmtime, at which point we'll update the versions again. * Update another version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #7272 to the 14.0.0 release branch to get version numbers into WASI interfaces that Wasmtime supports sooner rather than later. This uses the exact same date as main, 2023-10-18, so I'll have a follow-up PR to
mainwhich updates those dates further to havemainbe difference since WITs have changed.